[webkit-reviews] review granted: [Bug 189438] [MediaCapabilities] Implement MediaEngineConfigurationFactory registration : [Attachment 349317] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 15:37:28 PDT 2018


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 189438: [MediaCapabilities] Implement MediaEngineConfigurationFactory
registration
https://bugs.webkit.org/show_bug.cgi?id=189438

Attachment 349317: Patch

https://bugs.webkit.org/attachment.cgi?id=349317&action=review




--- Comment #15 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 349317
  --> https://bugs.webkit.org/attachment.cgi?id=349317
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349317&action=review

> Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:39
> +typedef struct __CVBuffer *CVPixelBufferRef;
> +typedef struct __IOSurface *IOSurfaceRef;
> +

Is this supposed to be part of this patch?


More information about the webkit-reviews mailing list