[webkit-reviews] review granted: [Bug 190645] Web Inspector: ⌃G to jump to line in CSS file wipes the line : [Attachment 352520] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 190645: Web Inspector: ⌃G to jump to line in CSS file wipes the line
https://bugs.webkit.org/show_bug.cgi?id=190645

Attachment 352520: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=352520&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 352520
  --> https://bugs.webkit.org/attachment.cgi?id=352520
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=352520&action=review

r=me

> Source/WebInspectorUI/ChangeLog:14
> +	   it is clear this is only on a successful value and not an invalid
valid.

Wording: "an invalid valid"

> Source/WebInspectorUI/ChangeLog:23
> +	   Prevent defaut on the event whenever we dismiss the dialog.

defaut -> default