[webkit-reviews] review granted: [Bug 190653] [WebGPU] Implement WebGPU bindings up through WebGPUDevice creation : [Attachment 352521] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 190653: [WebGPU] Implement WebGPU bindings up through WebGPUDevice creation
https://bugs.webkit.org/show_bug.cgi?id=190653

Attachment 352521: Patch

https://bugs.webkit.org/attachment.cgi?id=352521&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 352521
  --> https://bugs.webkit.org/attachment.cgi?id=352521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352521&action=review

> Source/WebCore/Modules/webgpu/WebGPU.cpp:46
> +    promise.resolve(WebGPUAdapter::create(descriptor));

'eyyyyyyy

> Source/WebCore/Modules/webgpu/WebGPUDevice.h:42
> +    WebGPUAdapter& adapter() const { return *m_adapter.get(); } // FIXME:
Probably not right; possible to deref nullptr.

this is definitely not right.