[webkit-reviews] review requested: [Bug 190653] [WebGPU] Implement WebGPU bindings up through WebGPUDevice creation : [Attachment 352521] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has asked  for review:
Bug 190653: [WebGPU] Implement WebGPU bindings up through WebGPUDevice creation
https://bugs.webkit.org/show_bug.cgi?id=190653

Attachment 352521: Patch

https://bugs.webkit.org/attachment.cgi?id=352521&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 352521
  --> https://bugs.webkit.org/attachment.cgi?id=352521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352521&action=review

> Source/WebCore/Modules/webgpu/DOMWindowWebGPU.cpp:49
> +// static

Remove this.

> Source/WebCore/Modules/webgpu/DOMWindowWebGPU.cpp:61
> +// static

Same.

> Source/WebCore/Modules/webgpu/DOMWindowWebGPU.idl:27
> +// Add a "webgpu" member to Window that contains the global instance of a
"WebGPU"

I don't think we need this comment.

> Source/WebCore/Modules/webgpu/WebGPU.cpp:37
> +// static

Remove.

> Source/WebCore/Modules/webgpu/WebGPU.cpp:46
> +    WebGPUAdapterPromise promise = WTFMove(deferred);
> +    promise.resolve(WebGPUAdapter::create(descriptor));

This is ok for now, but this will eventually keep a list of active adapters and
pass out references to them.

> Source/WebCore/Modules/webgpu/WebGPU.cpp:49
> +WebGPU::WebGPU() = default;

I think this should go after ::create, or in the header.

> Source/WebCore/Modules/webgpu/WebGPU.h:34
> +class WebGPUAdapter;

Don't need this.

> Source/WebCore/Modules/webgpu/WebGPUAdapter.cpp:37
> +// static

Remove.

> Source/WebCore/Modules/webgpu/WebGPUDevice.h:47
> +    WeakPtr<WebGPUAdapter> m_adapter;

Why is this weak?