[webkit-reviews] review denied: [Bug 190354] Web Inspector: CSP request payload on medium.com is unreadable, should be pretty-printed : [Attachment 351946] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 190354: Web Inspector: CSP request payload on medium.com is unreadable,
should be pretty-printed
https://bugs.webkit.org/show_bug.cgi?id=190354

Attachment 351946: Patch

https://bugs.webkit.org/attachment.cgi?id=351946&action=review




--- Comment #8 from Brian Burg <bburg at apple.com> ---
Comment on attachment 351946
  --> https://bugs.webkit.org/attachment.cgi?id=351946
Patch

I don't like the data flow here. The patch pretends the content is formattable
but canBeFormatted() is still false. Then it adds a new event that is only used
in this one case for one subclass. It would make more sense, IMO, to alter
TextEditor.canBeFormatted() to return true in this case. Then call
TextEditor._format(true), which will pretty-print the text again, fire
WI.TextEditor.Event.FormattingDidChange, and that will cause the button to be
updated appropriately.