[webkit-reviews] review granted: [Bug 188598] [JSC] Remove gcc warnings on mips and armv7 : [Attachment 351974] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 10 11:56:17 PDT 2018
Mark Lam <mark.lam at apple.com> has granted Guillaume Emont
<guijemont at igalia.com>'s request for review:
Bug 188598: [JSC] Remove gcc warnings on mips and armv7
https://bugs.webkit.org/show_bug.cgi?id=188598
Attachment 351974: Patch
https://bugs.webkit.org/attachment.cgi?id=351974&action=review
--- Comment #34 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 351974
--> https://bugs.webkit.org/attachment.cgi?id=351974
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=351974&action=review
r=me if EWS bots are green.
> Source/bmalloc/bmalloc/Algorithm.h:186
> + * Copied from WTF/wtf/StdLibExtras.h
No need to use C style comments. Can you switch this to a C++ comment?
More information about the webkit-reviews
mailing list