[webkit-reviews] review denied: [Bug 190330] Web Inspector: detail view is not re-shown after sorting the Network table : [Attachment 351978] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 190330: Web Inspector: detail view is not re-shown after sorting the
Network table
https://bugs.webkit.org/show_bug.cgi?id=190330

Attachment 351978: Patch

https://bugs.webkit.org/attachment.cgi?id=351978&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 351978
  --> https://bugs.webkit.org/attachment.cgi?id=351978
Patch

r-, as applying the patch causes an uncaught exception.

Steps to Reproduce:
1. Goto daringfireball.bnet
2. Network tab > select the first row
3. Sort the Name column

=> Uncaught exception:
TypeError:​ this._showDetailView is not a function. (In
'this._showDetailView(this._selectedObject)​', 'this._showDetailView' is
undefined)​ (at NetworkTableContentView.js:​1681:​29)​
    _restoreSelectedRow @ NetworkTableContentView.js:​1681:​29
    _updateFilteredEntries @ NetworkTableContentView.js:​1552:​33
    tableSortChanged @ NetworkTableContentView.js:​337:​36
    sortOrder @ Table.js:​160:​50
    _handleHeaderCellClicked @ Table.js:​1308:​13
    _handleHeaderCellClicked @ [native code]​