[webkit-reviews] review granted: [Bug 185945] [Baseline] Remove a hack for DCE removal of NewFunction : [Attachment 341244] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185945: [Baseline] Remove a hack for DCE removal of NewFunction
https://bugs.webkit.org/show_bug.cgi?id=185945

Attachment 341244: Patch

https://bugs.webkit.org/attachment.cgi?id=341244&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 341244
  --> https://bugs.webkit.org/attachment.cgi?id=341244
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=341244&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6338
> +	       addToGraph(Phantom, scope);

Put this after the set?

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:6375
> +	       set(VirtualRegister(currentInstruction[1].u.operand),
addToGraph(op, OpInfo(frozen), scope));

ditto