[webkit-reviews] review granted: [Bug 182214] [ESNext][BigInt] Implement "+" and "-" unary operation : [Attachment 340808] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 182214: [ESNext][BigInt] Implement "+" and "-" unary operation
https://bugs.webkit.org/show_bug.cgi?id=182214

Attachment 340808: Patch

https://bugs.webkit.org/attachment.cgi?id=340808&action=review




--- Comment #46 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 340808
  --> https://bugs.webkit.org/attachment.cgi?id=340808
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340808&action=review

r=me with comments.

> Source/JavaScriptCore/jit/JITOperations.cpp:2720
> +	   return JSValue::encode(JSValue(JSBigInt::unaryMinus(vm,
asBigInt(primValue))));

Do not need `JSValue()` wrap around JSBigInt result.
`JSValue::encode(JSBigInt::xxx())` works.

> Source/JavaScriptCore/jit/JITOperations.cpp:2740
> +	   JSValue result = JSValue(JSBigInt::unaryMinus(vm,
asBigInt(primValue)));

Do not need this `JSValue()` wrap. Just,

JSBigInt* result = JSBigInt::xxx();
arithProfile.observeRusult(result);

works.

> Source/JavaScriptCore/jit/JITOperations.cpp:2785
> +	   JSValue result = JSValue(JSBigInt::unaryMinus(vm,
asBigInt(primValue)));

Ditto.

> Source/JavaScriptCore/jit/JITOperations.cpp:2817
> +	   JSValue result = JSValue(JSBigInt::unaryMinus(vm,
asBigInt(primValue)));

Ditto.

> Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:406
> +	   JSValue result = JSValue(JSBigInt::unaryMinus(exec->vm(),
asBigInt(primValue)));

Ditto.