[webkit-reviews] review granted: [Bug 185968] Enforce invariant that GetterSetter objects are immutable. : [Attachment 341237] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 185968: Enforce invariant that GetterSetter objects are immutable.
https://bugs.webkit.org/show_bug.cgi?id=185968

Attachment 341237: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=341237&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 341237
  --> https://bugs.webkit.org/attachment.cgi?id=341237
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=341237&action=review

r=me

>> Source/JavaScriptCore/ChangeLog:3
>> +	    Enforce invariant that GetterSetter objects are invariant.
> 
> This should say that GetterSetters are immutable, not “invariant”.

is there a test or some explanation here of what's going on?

> Source/JavaScriptCore/runtime/JSObject.cpp:3582
> +    RETURN_IF_EXCEPTION(scope, false);

Why can this throw?