[webkit-reviews] review denied: [Bug 187851] Add CEReactions=NotNeeded for reactions only needed for customized builtins : [Attachment 345839] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 187851: Add CEReactions=NotNeeded for reactions only needed for customized
builtins
https://bugs.webkit.org/show_bug.cgi?id=187851

Attachment 345839: Patch

https://bugs.webkit.org/attachment.cgi?id=345839&action=review




--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 345839
  --> https://bugs.webkit.org/attachment.cgi?id=345839
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345839&action=review

> Source/WebCore/dom/CustomElementReactionQueue.h:109
> +class CustomElementReactionStackWithReactionsForbidden : public
CustomElementReactionStack {

I don't think we can afford to instantiate CustomElementReactionStack
everywhere like this.
We need to create a completely new class (i.e. doesn't inherit from
CustomElementReactionStack) which clang can optimize way.
r- because of this.

Also, this class name is rather verbose. How about
UnneededCustomElementReactionStack?

> Source/WebCore/html/HTMLAnchorElement.idl:22
> +    [CEReactions=NotNeeded, Reflect] attribute DOMString charset;

Let's split the patch to make the binding code & actual IDL changes.