[webkit-reviews] review granted: [Bug 186751] Remove the SVG elements' attributes macros : [Attachment 346217] Remove SVG macros from SVGElement

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 186751: Remove the SVG elements' attributes macros
https://bugs.webkit.org/show_bug.cgi?id=186751

Attachment 346217: Remove SVG macros from SVGElement

https://bugs.webkit.org/attachment.cgi?id=346217&action=review




--- Comment #102 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346217
  --> https://bugs.webkit.org/attachment.cgi?id=346217
Remove SVG macros from SVGElement

View in context: https://bugs.webkit.org/attachment.cgi?id=346217&action=review

> Source/WebCore/svg/SVGElement.h:152
> +    const auto& className() const { return m_className.currentValue(); }
> +    auto classNameAnimated() { return m_className.animatedProperty(); }

Those autos are bad too. Are they Strings, AtomicStrings, StringViews,
StringImpls?