[webkit-reviews] review granted: [Bug 186751] Remove the SVG elements' attributes macros : [Attachment 346212] Register SVGLangSpace attributes into SVGAttributeRegistry

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 17:43:30 PDT 2018


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 186751: Remove the SVG elements' attributes macros
https://bugs.webkit.org/show_bug.cgi?id=186751

Attachment 346212: Register SVGLangSpace attributes into SVGAttributeRegistry

https://bugs.webkit.org/attachment.cgi?id=346212&action=review




--- Comment #101 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 346212
  --> https://bugs.webkit.org/attachment.cgi?id=346212
Register SVGLangSpace attributes into SVGAttributeRegistry

View in context: https://bugs.webkit.org/attachment.cgi?id=346212&action=review

> Source/WebCore/svg/SVGLangSpace.cpp:71
> +    if (auto* renderer =
downcast<RenderSVGShape>(m_contextElement.renderer())) {

Weird, why is RenderSVGShape stuff here?

> Source/WebCore/svg/SVGLangSpace.h:45
> +    static auto& attributeRegistry() { return
AttributeOwnerProxy::attributeRegistry(); }

I hate that auto. I've no idea what the return type is.


More information about the webkit-reviews mailing list