[webkit-reviews] review granted: [Bug 188593] Web Inspector: Table should not center rows when scrolling them into view : [Attachment 347139] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 188593: Web Inspector: Table should not center rows when scrolling them
into view
https://bugs.webkit.org/show_bug.cgi?id=188593

Attachment 347139: Patch

https://bugs.webkit.org/attachment.cgi?id=347139&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 347139
  --> https://bugs.webkit.org/attachment.cgi?id=347139
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347139&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Table.js:1176
> +	       row.scrollIntoViewIfNeeded(false);

Looks like this might be dropped in favor of `Element.scrollIntoView()` at some
point in the future.  We might have to change it then.