[webkit-reviews] review granted: [Bug 188449] Web Inspector: Remove TreeOutlineDataGridSynchronizer : [Attachment 346859] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 14 21:57:46 PDT 2018


Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 188449: Web Inspector: Remove TreeOutlineDataGridSynchronizer
https://bugs.webkit.org/show_bug.cgi?id=188449

Attachment 346859: Patch

https://bugs.webkit.org/attachment.cgi?id=346859&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 346859
  --> https://bugs.webkit.org/attachment.cgi?id=346859
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346859&action=review

r=me, nice cleanup

> Source/WebInspectorUI/ChangeLog:27
> +	   (WI.TimelineDataGrid.prototype.dataGridNodeForTreeElement): Deleted.

This function also seems to be defined on `WI.RenderingFrameTimelineView`.  Is
that related, or "leftover"?


More information about the webkit-reviews mailing list