[webkit-reviews] review granted: [Bug 188552] [GStreamer][GL] useless ifdef in pushTextureToCompositor : [Attachment 347070] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 188552: [GStreamer][GL] useless ifdef in pushTextureToCompositor
https://bugs.webkit.org/show_bug.cgi?id=188552

Attachment 347070: Patch

https://bugs.webkit.org/attachment.cgi?id=347070&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 347070
  --> https://bugs.webkit.org/attachment.cgi?id=347070
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347070&action=review

I think it is ok. Anyway, I'd wait until somebody like Miguel has a look at it
as well.

> Source/WebCore/ChangeLog:10
> +	   There's no need for a ifdef because the frame holder already

Nit: I think it is aN ifdef

> Source/WebCore/ChangeLog:11
> +	   ensures a valid texture ID will set if it maps a GL video frame.

will BE set?