[webkit-reviews] review granted: [Bug 159464] Implement Same-Site cookies : [Attachment 338197] Patch and layout tests

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 159464: Implement Same-Site cookies
https://bugs.webkit.org/show_bug.cgi?id=159464

Attachment 338197: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=338197&action=review




--- Comment #22 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 338197
  --> https://bugs.webkit.org/attachment.cgi?id=338197
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=338197&action=review

This looks reasonable. Is it safe to land for internal machines?

> Source/WebCore/loader/CookieJar.cpp:64
> +    return SameSiteInfo::create(document.loader()->request());

If we are inlining, might this be better?

if (auto loader = document.loader())
    return SameSiteInfo::create(loader->request());

return { }]

> Source/WebCore/platform/network/mac/CookieJarMac.mm:-151
> -    }];

Was this synchronous behavior important to the logic? Is changing to
'cookiesForURL' an issue?