[webkit-reviews] review granted: [Bug 184756] Rename WindowProxyController to WindowProxy : [Attachment 338275] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 18 20:28:26 PDT 2018


Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 184756: Rename WindowProxyController to WindowProxy
https://bugs.webkit.org/show_bug.cgi?id=184756

Attachment 338275: Patch

https://bugs.webkit.org/attachment.cgi?id=338275&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 338275
  --> https://bugs.webkit.org/attachment.cgi?id=338275
Patch

I think its a bit odd that the class is called WindowProxy and its wrapper is
JSDOMWindowProxy, but I think maybe we should address that by renaming
JSDOMWindowProxy at some point. r=me.


More information about the webkit-reviews mailing list