[webkit-reviews] review denied: [Bug 184766] Tool scripts should not use PrivilegedAPI from 'public/v3/privileged-api.js'. : [Attachment 338293] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 18 20:44:35 PDT 2018
Ryosuke Niwa <rniwa at webkit.org> has denied dewei_zhu at apple.com's request for
review:
Bug 184766: Tool scripts should not use PrivilegedAPI from
'public/v3/privileged-api.js'.
https://bugs.webkit.org/show_bug.cgi?id=184766
Attachment 338293: Patch
https://bugs.webkit.org/attachment.cgi?id=338293&action=review
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 338293
--> https://bugs.webkit.org/attachment.cgi?id=338293
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=338293&action=review
> Websites/perf.webkit.org/server-tests/api-upload-root-tests.js:12
> +global.PrivilegedAPI =
require('../public/v3/privileged-api.js').PrivilegedAPI;
This should probably be done in TestServer.inject so that when all these tests
are ran at the same time,
we use the correct version of PrivilegedAPI instead of whichever loaded last.
More information about the webkit-reviews
mailing list