[webkit-reviews] review granted: [Bug 169707] Provide bug information when https://webkit.org/b/# URLs are added in comments : [Attachment 311047] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted  review:
Bug 169707: Provide bug information when https://webkit.org/b/# URLs are added
in comments
https://bugs.webkit.org/show_bug.cgi?id=169707

Attachment 311047: Patch

https://bugs.webkit.org/attachment.cgi?id=311047&action=review




--- Comment #11 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 311047
  --> https://bugs.webkit.org/attachment.cgi?id=311047
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311047&action=review

r=me with adding of a WEBKIT_CHANGES comment.

>> Websites/bugs.webkit.org/Bugzilla/Template.pm:214
>> +		  ~egox;
> 
> Perhaps this should be wrapped in:
> 
>     #if WEBKIT_CHANGES
>     ...
>     #endif
> 
> I think ddkilzer knows best here. Otherwise this looks good to me!

Yes, please add a comment, even if it's just this before the new code:

# WEBKIT_CHANGES

This type of comment makes a full-tree diff to upstream lets future mergers
know this was an intentional change rather than an accident or a merge
artifact.

Note the "#" in Perl is a comment character so the use of #if/#endif is just
gratuitous decoration.	:)