[webkit-reviews] review denied: [Bug 172552] REGRESSION (r206481): Don't assume frameCount() is larger than or equal to the size of the image frame cache : [Attachment 311144] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 24 13:35:06 PDT 2017


Geoffrey Garen <ggaren at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 172552: REGRESSION (r206481): Don't assume frameCount() is larger than or
equal to the size of the image frame cache
https://bugs.webkit.org/show_bug.cgi?id=172552

Attachment 311144: Patch

https://bugs.webkit.org/attachment.cgi?id=311144&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 311144
  --> https://bugs.webkit.org/attachment.cgi?id=311144
Patch

The purpose of shrink() and grow() is to optimize the case when you know that
you're shrinking or growing, by avoiding a check.

Clients that don't know what kind of size change they're making can call
resize().


More information about the webkit-reviews mailing list