[webkit-reviews] review granted: [Bug 172541] System sleeps while playing to wireless target, ending stream. : [Attachment 311136] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 172541: System sleeps while playing to wireless target, ending stream.
https://bugs.webkit.org/show_bug.cgi?id=172541

Attachment 311136: Patch

https://bugs.webkit.org/attachment.cgi?id=311136&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 311136
  --> https://bugs.webkit.org/attachment.cgi?id=311136
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311136&action=review

> Source/WebCore/ChangeLog:14
> +	   one that is playing but not visible, and one that is playing
remotely.

Nit: "one that is" => "and one that is"

> Source/WebCore/html/HTMLMediaElement.cpp:6356
> +	       m_sleepDisabler = SleepDisabler::create("com.apple.WebCore:
HTMLMediaElement playback", type);

Nit: it may help debugging later if the type is in the name string.

> Source/WebCore/html/HTMLMediaElement.cpp:6360
> +	   m_player->setShouldDisableSleep(shouldDisableSleep ==
SleepType::Display);

Nit: setShouldDisableSleep should probably be renamed to something like
setShouldDisableDisplaySleep