[webkit-reviews] review granted: [Bug 171444] Speedometer: Add a React.js TodoMVC implementation : [Attachment 308579] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 9 14:26:26 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Addy Osmani <addyo at chromium.org>'s
request for review:
Bug 171444: Speedometer: Add a React.js TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171444

Attachment 308579: Patch

https://bugs.webkit.org/attachment.cgi?id=308579&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 308579
  --> https://bugs.webkit.org/attachment.cgi?id=308579
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308579&action=review

> PerformanceTests/ChangeLog:7
> +	   Speedometer: add React.js TodoMVC implementation

Again, we need a blank line before this.

> PerformanceTests/ChangeLog:10
> +	   (app.Utils.uuid):

Also remove these inline comments.


More information about the webkit-reviews mailing list