[webkit-reviews] review granted: [Bug 171325] Speedometer: Add a Vue.js TodoMVC implementation : [Attachment 308252] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Addy Osmani <addyo at chromium.org>'s
request for review:
Bug 171325: Speedometer: Add a Vue.js TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171325

Attachment 308252: Patch

https://bugs.webkit.org/attachment.cgi?id=308252&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 308252
  --> https://bugs.webkit.org/attachment.cgi?id=308252
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308252&action=review

> PerformanceTests/ChangeLog:7
> +	   Adds a Vue.js TodoMVC implementation to Speedometer

Ditto a blank line before this.

> PerformanceTests/ChangeLog:9
> +	   *
Speedometer/resources/todomvc/architecture-examples/vuejs-cli/.babelrc: Added.

Do we really need to include these configuration files?

> PerformanceTests/ChangeLog:19
> +	   (body,button,html):

Ditto remove these comments.