[webkit-reviews] review denied: [Bug 171452] Speedometer: Add an ES2015 (Babel + Webpack) TodoMVC implementation : [Attachment 308630] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Addy Osmani <addyo at chromium.org>'s
request for review:
Bug 171452: Speedometer: Add an ES2015 (Babel + Webpack) TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171452

Attachment 308630: Patch

https://bugs.webkit.org/attachment.cgi?id=308630&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 308630
  --> https://bugs.webkit.org/attachment.cgi?id=308630
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308630&action=review

> PerformanceTests/ChangeLog:7
> +	   Adds ES2015 Babel + Webpack TodoMVC implem

Again, we need a blank line before this.

> PerformanceTests/ChangeLog:11
> +	   *
Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle
.app.421eb6baca02218e985e.js: Added.

This file access localStorage. We probably want to avoid storing things into
localStorage.
r- because of this.

> PerformanceTests/ChangeLog:12
> +	   (o):

And remove these inline comments since we're just importing files.