[webkit-reviews] review granted: [Bug 172621] Web Inspector: Don't create NavigationSidebarPanel classes until they are needed by a Tab : [Attachment 311323] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 2 10:09:02 PDT 2017
Timothy Hatcher <timothy at hatcher.name> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 172621: Web Inspector: Don't create NavigationSidebarPanel classes until
they are needed by a Tab
https://bugs.webkit.org/show_bug.cgi?id=172621
Attachment 311323: Patch
https://bugs.webkit.org/attachment.cgi?id=311323&action=review
--- Comment #3 from Timothy Hatcher <timothy at hatcher.name> ---
Comment on attachment 311323
--> https://bugs.webkit.org/attachment.cgi?id=311323
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=311323&action=review
Looks good.
> Source/WebInspectorUI/UserInterface/Views/TabContentView.js:182
> get navigationSidebarCollapsedSetting() { return
this._navigationSidebarCollapsedSetting; }
Add a new line above since the new getter is not a single line.
More information about the webkit-reviews
mailing list