[webkit-reviews] review granted: [Bug 172663] Web Inspector: Existing query in Search tab doesn't perform search on reload : [Attachment 311392] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 2 10:06:02 PDT 2017


Timothy Hatcher <timothy at hatcher.name> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 172663: Web Inspector: Existing query in Search tab doesn't perform search
on reload
https://bugs.webkit.org/show_bug.cgi?id=172663

Attachment 311392: Patch

https://bugs.webkit.org/attachment.cgi?id=311392&action=review




--- Comment #3 from Timothy Hatcher <timothy at hatcher.name> ---
Comment on attachment 311392
  --> https://bugs.webkit.org/attachment.cgi?id=311392
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311392&action=review

> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:418
> +	       performSearchLink.textContent = WebInspector.UIString("Search
Again");

Neat! I'd like this better if it was a rounded rect button, not a link.


More information about the webkit-reviews mailing list