[webkit-reviews] review granted: [Bug 172608] Web Inspector: The CodeMirror instance in the ConsolePrompt does't need to be refreshed each time it is shown : [Attachment 311287] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 172608: Web Inspector: The CodeMirror instance in the ConsolePrompt does't
need to be refreshed each time it is shown
https://bugs.webkit.org/show_bug.cgi?id=172608

Attachment 311287: Patch

https://bugs.webkit.org/attachment.cgi?id=311287&action=review




--- Comment #6 from Timothy Hatcher <timothy at hatcher.name> ---
Comment on attachment 311287
  --> https://bugs.webkit.org/attachment.cgi?id=311287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311287&action=review

Okay, as long as you tested this well!

> Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js:-120
> -	   this._codeMirror.refresh();

I think we did this because CodeMirror gets in a bad state when it has been
hidden/out of the document. Specifically the caret would be broken.