[webkit-reviews] review granted: [Bug 174651] Minor Node->Element type tightening fixes : [Attachment 315919] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 19 22:16:33 PDT 2017
Sam Weinig <sam at webkit.org> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 174651: Minor Node->Element type tightening fixes
https://bugs.webkit.org/show_bug.cgi?id=174651
Attachment 315919: Patch
https://bugs.webkit.org/attachment.cgi?id=315919&action=review
--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 315919
--> https://bugs.webkit.org/attachment.cgi?id=315919
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=315919&action=review
> Source/WebCore/dom/Document.cpp:386
> + Frame* frame = element.document().frame();
You could use auto* here.
> Source/WebCore/editing/Editor.cpp:466
> + Element* target = findEventTargetFromSelection();
You could use auto* here.
> Source/WebCore/editing/Editor.cpp:474
> + Element* target = findEventTargetFromSelection();
You could use auto* here.
> Source/WebCore/editing/Editor.cpp:782
> + Element* target = findEventTargetFromSelection();
You could use auto* here.
> Source/WebCore/editing/Editor.cpp:809
> + Element* target = selection.start().element();
You could use auto* here.
More information about the webkit-reviews
mailing list