[webkit-reviews] review requested: [Bug 134392] curl: Fix several deadlocks : [Attachment 315971] remove mutex

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 19 22:17:18 PDT 2017


Basuke Suzuki <Basuke.Suzuki at sony.com> has asked  for review:
Bug 134392: curl: Fix several deadlocks
https://bugs.webkit.org/show_bug.cgi?id=134392

Attachment 315971: remove mutex

https://bugs.webkit.org/attachment.cgi?id=315971&action=review




--- Comment #3 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
Created attachment 315971

  --> https://bugs.webkit.org/attachment.cgi?id=315971&action=review

remove mutex

Because JobManager calls callback sequentially from phase to phase, there is no
need to maintain thread safety by mutex. m_response is the only object which is
touched from background and main thread, all header received event is the last
method to touch the response and all manipulation is finished by that timing.


More information about the webkit-reviews mailing list