[webkit-reviews] review requested: [Bug 134393] curl: Don't try to close & move the downloaded file twice : [Attachment 315970] Remove unrelated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 19 22:06:06 PDT 2017
Basuke Suzuki <Basuke.Suzuki at sony.com> has asked for review:
Bug 134393: curl: Don't try to close & move the downloaded file twice
https://bugs.webkit.org/show_bug.cgi?id=134393
Attachment 315970: Remove unrelated patch
https://bugs.webkit.org/attachment.cgi?id=315970&action=review
--- Comment #7 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
Created attachment 315970
--> https://bugs.webkit.org/attachment.cgi?id=315970&action=review
Remove unrelated patch
After refactoring the architecture of job manager, tasks are more clear when it
would be called. Also with use of lambda when starting the download, the
lifecycle of the download object is more clear and confident. The downloaded
file will be move to the destination on success() or deleted on failure or
cancelation.
Also deleted unused private static methods.
More information about the webkit-reviews
mailing list