[webkit-reviews] review granted: [Bug 171435] [iOS] We should not take a background assertion for the UIProcess when app is MobileMail : [Attachment 308545] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 171435: [iOS] We should not take a background assertion for the UIProcess
when app is MobileMail
https://bugs.webkit.org/show_bug.cgi?id=171435

Attachment 308545: Patch

https://bugs.webkit.org/attachment.cgi?id=308545&action=review




--- Comment #6 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 308545
  --> https://bugs.webkit.org/attachment.cgi?id=308545
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308545&action=review

It's still not super clear to me why it's OK to avoid taking any assertion in
Mail. If we're busy writing to a file, we might not finish.

> Source/WebKit2/UIProcess/ios/ProcessAssertionIOS.mm:215
> +    // There is no need to take UIAssertion if the application is MobileMail
and it has its own (rdar://problem/31132330).

I'd change this comment to "Mail has a special entitlement to do unbounded work
in the background. Avoid taking an assertion because it might drain the
battery".