[webkit-reviews] review granted: [Bug 171284] getUserMedia video streams should follow device orientation : [Attachment 308475] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 171284: getUserMedia video streams should follow device orientation
https://bugs.webkit.org/show_bug.cgi?id=171284

Attachment 308475: Patch

https://bugs.webkit.org/attachment.cgi?id=308475&action=review




--- Comment #15 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 308475
  --> https://bugs.webkit.org/attachment.cgi?id=308475
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308475&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSource.h:250
> +    operator bool()	const { return !!captureSource; }

Is the "!!" necessary?

> Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:167
> +    // FIXME: Do something with m_deviceOrientation

Nit: you could not that this is https://bugs.webkit.org/show_bug.cgi?id=169822.

> Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:140
> +	   if (!!audioSource)

Why is the "!!" necessary since CaptureSourceOrError has an operator bool()?

> Source/WebCore/platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:149
> +	   if (!!videoSource)

Ditto.

> Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:91
> +	       if (!!sourceOrError &&
sourceOrError.captureSource->supportsConstraints(audioConstraints,
invalidConstraint))

Ditto.

> Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:139
> +	       if (!!sourceOrError)

Ditto.

> Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:143
> +	       if (!!sourceOrError)

Ditto.

> Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:152
> +	       if (!!sourceOrError)

Ditto.

> Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:156
> +	       if (!!sourceOrError)

Ditto.

> Source/WebKit2/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:144
> +    succeeded = !!sourceOrError;

Ditto.

> Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:101
> -    ASSERT(!idToHistoryItemMap().contains(itemID));
> +//	 ASSERT(!idToHistoryItemMap().contains(itemID));

Oops!