[webkit-reviews] review granted: [Bug 171410] Unify how BitmapImage handles the availability of a decoded for large and animated images : [Attachment 308487] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 28 10:53:11 PDT 2017
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 171410: Unify how BitmapImage handles the availability of a decoded for
large and animated images
https://bugs.webkit.org/show_bug.cgi?id=171410
Attachment 308487: Patch
https://bugs.webkit.org/attachment.cgi?id=308487&action=review
--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 308487
--> https://bugs.webkit.org/attachment.cgi?id=308487
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=308487&action=review
> Source/WebCore/ChangeLog:9
> + Make BitmapImage calls ImageObserver::imageFrameAvailable() whenever
a
calls -> call
> Source/WebCore/loader/cache/CachedImageClient.h:43
> + virtual bool imageFrameAvailable(CachedImage& image, bool, const
IntRect* changeRect) { imageChanged(&image, changeRect); return false; }
Please add a comment saying what the return value means, or return a
self-explanatory enum.
> Source/WebCore/platform/graphics/BitmapImage.cpp:414
> + imageObserver()->imageFrameAvailable(this, true);
boolean trap. Use an enum?
> Source/WebCore/platform/graphics/BitmapImage.cpp:460
> + imageObserver()->imageFrameAvailable(this, false);
boolean trap.
> Source/WebCore/rendering/RenderElement.cpp:1508
> + // Large images should repaint even if they are outside the viewport
rectangle
> + // because they should be inside the TileCoverageRect.
> + if (shouldRepaint || (!isAnimating && image.image() &&
image.image()->isBitmapImage()))
> + imageChanged(&image, changeRect);
This seems like a behavior change. Can it be tested?
> Source/WebCore/svg/graphics/SVGImageClients.h:55
> + // If m_image->m_page is null, we're being destructed.
destructed -> destroyed
More information about the webkit-reviews
mailing list