[webkit-reviews] review granted: [Bug 170909] WebAssembly: fast memory cleanups : [Attachment 307493] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 19 12:44:32 PDT 2017
Saam Barati <sbarati at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 170909: WebAssembly: fast memory cleanups
https://bugs.webkit.org/show_bug.cgi?id=170909
Attachment 307493: patch
https://bugs.webkit.org/attachment.cgi?id=307493&action=review
--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307493
--> https://bugs.webkit.org/attachment.cgi?id=307493
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=307493&action=review
r=me
> Source/JavaScriptCore/b3/B3LowerToAir.cpp:3173
> + ASSERT(value->bounds().maximum <= value->redzoneLimit());
Nit: It seems weird that B3/Air are asserting this, and that this is a
function. I would just assert this when making the node.
> Source/JavaScriptCore/b3/B3Validate.cpp:478
> +
VALIDATE(value->as<WasmBoundsCheckValue>()->bounds().maximum <=
value->as<WasmBoundsCheckValue>()->redzoneLimit(), ("At ", *value));
ditto
More information about the webkit-reviews
mailing list