[webkit-reviews] review granted: [Bug 170967] ASAN Crash running LayoutTests/inspector/worker tests : [Attachment 307419] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 170967: ASAN Crash running LayoutTests/inspector/worker tests
https://bugs.webkit.org/show_bug.cgi?id=170967

Attachment 307419: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=307419&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 307419
  --> https://bugs.webkit.org/attachment.cgi?id=307419
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=307419&action=review

> Source/WebCore/workers/WorkerMessagingProxy.cpp:242
> -	   delete this;
> +	   deref();

This is strange lifetime management.  Is there really nothing that can own
this?  This change does make it so we can protect it in the lambda, though, so
r=me on that.