[webkit-reviews] review granted: [Bug 171002] REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed : [Attachment 307496] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 19 12:40:51 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 171002: REGRESSION (r213168): An extra Web Content process is spun up on
launch and is never closed
https://bugs.webkit.org/show_bug.cgi?id=171002

Attachment 307496: Patch

https://bugs.webkit.org/attachment.cgi?id=307496&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 307496
  --> https://bugs.webkit.org/attachment.cgi?id=307496
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307496&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm:51
> +    EXPECT_EQ([pool _webProcessCount], (size_t)1);

Do 1u, 1ull, or static_cast<size_t>(1) work?  I don't like this c-style cast.


More information about the webkit-reviews mailing list