[webkit-reviews] review granted: [Bug 136898] [EME][Mac] Support secure proof of key release in the com.apple.fps.2_0 keysystem. : [Attachment 238271] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 136898: [EME][Mac] Support secure proof of key release in the
com.apple.fps.2_0 keysystem.
https://bugs.webkit.org/show_bug.cgi?id=136898

Attachment 238271: Patch
https://bugs.webkit.org/attachment.cgi?id=238271&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238271&action=review


>
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC
.mm:141
> +    if (!initialized) {

If you use "if (!sessionDirectoryPath.isEmpty())" you can lose the static bool.


>
Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC
.mm:147
> +	   sessionDirectoryPath.get().append("AVStreamSession/");

Should use ASCIILiteral.