[webkit-reviews] review granted: [Bug 136966] build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments : [Attachment 238399] proposed fix

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 136966: build.webkit.org/dashboard: Pending builds don't show up when there
is a commit with no comments
https://bugs.webkit.org/show_bug.cgi?id=136966

Attachment 238399: proposed fix
https://bugs.webkit.org/attachment.cgi?id=238399&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=238399&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/T
rac.js:105
> -	   if (parsedDescription.firstChild.className === "changes") {
> +	   if (parsedDescription.firstChild &&
parsedDescription.firstChild.className === "changes") {

We may want to consider caching parsedDescription.firstChild in a local
variable to avoid computing it again since we reference it four times in this
function.