[webkit-reviews] review denied: [Bug 136874] [Win] __BUILD_NUMBER_SHORT__ not defined : [Attachment 238216] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Alex Christensen
<alex.christensen at flexsim.com>'s request for review:
Bug 136874: [Win] __BUILD_NUMBER_SHORT__ not defined
https://bugs.webkit.org/show_bug.cgi?id=136874

Attachment 238216: Patch
https://bugs.webkit.org/attachment.cgi?id=238216&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
__BUILD_NUMBER_SHORT_ should be created by auto-version.pl (and defined in
"autoversion.h"). We don't want to make the change you propose. Most likely you
just need to make sure auto-version.pl runs during the build to create the
necessary autoversion.h file.