[webkit-reviews] review granted: [Bug 136380] LegacyProfiler: remove redundant ProfileNode members and other cleanup : [Attachment 237418] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 2 10:59:47 PDT 2014


Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 136380: LegacyProfiler: remove redundant ProfileNode members and other
cleanup
https://bugs.webkit.org/show_bug.cgi?id=136380

Attachment 237418: Patch
https://bugs.webkit.org/attachment.cgi?id=237418&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237418&action=review


> Source/JavaScriptCore/profiler/ProfileNode.h:145
> -	   Vector<Call, 1> m_calls;
> +	   Vector<Call> m_calls;

Why this change? There will always be a minimum of 1 call, so it seems best to
have storage for it instead of another malloc right away.


More information about the webkit-reviews mailing list