[webkit-reviews] review granted: [Bug 135142] Web Inspector: Create a UI for displaying JavaScript type information : [Attachment 237407] patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Saam Barati
<saambarati1 at gmail.com>'s request for review:
Bug 135142: Web Inspector: Create a UI for displaying JavaScript type
information
https://bugs.webkit.org/show_bug.cgi?id=135142

Attachment 237407: patch
https://bugs.webkit.org/attachment.cgi?id=237407&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=237407&action=review


r=me

> Source/WebInspectorUI/ChangeLog:129
> +		
> +

Nit: Double empty line. And some tabs in the ChangeLog apparently.

>
Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorTokenTrackingControll
er.js:-196
>      _startTracking: function()
>      {
> -	   console.assert(!this._tracking);

This landed separately right?

> Source/WebInspectorUI/UserInterface/Views/TextContentView.js:58
> +   
this._showTypesButtonNavigationItem.addEventListener(WebInspector.ButtonNavigat
ionItem.Event.Clicked, function() {}, this);

If you are registering an empty event listener, just don't register an event
listener!