[webkit-reviews] review granted: [Bug 136352] Web Inspector: the profiler should not accrue time to nodes while the debugger is paused : [Attachment 237477] Proposed fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 136352: Web Inspector: the profiler should not accrue time to nodes while
the debugger is paused
https://bugs.webkit.org/show_bug.cgi?id=136352

Attachment 237477: Proposed fix
https://bugs.webkit.org/attachment.cgi?id=237477&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237477&action=review


> Source/JavaScriptCore/profiler/LegacyProfiler.cpp:141
> +   
callFunctionForProfilesWithGroup(std::bind(&ProfileGenerator::willExecute,
std::placeholders::_1, callerCallFrame, callIdentifier), m_currentProfiles,
callerCallFrame->lexicalGlobalObject()->profileGroup());

std::bind + std::placeholders === magic

> Source/JavaScriptCore/profiler/ProfileGenerator.cpp:131
> +    last.setTotalTime(m_debuggerPaused ? 0.0 : currentTime() -
last.startTime());

Couldn't we subtract out the time between pause and resume?