[webkit-reviews] review granted: [Bug 137253] [CSS Grid Layout] Pass the valid set of tracks to grow beyond growth limits : [Attachment 238927] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 137253: [CSS Grid Layout] Pass the valid set of tracks to grow beyond
growth limits
https://bugs.webkit.org/show_bug.cgi?id=137253

Attachment 238927: Patch
https://bugs.webkit.org/attachment.cgi?id=238927&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238927&action=review


> Source/WebCore/rendering/RenderGrid.cpp:584
> +void
RenderGrid::resolveContentBasedTrackSizingFunctionsForItems(GridTrackSizingDire
ction direction, GridSizingData& sizingData, GridItemWithSpan&
gridItemWithSpan, FilterFunction filterFunction, SizingFunction sizingFunction,
AccumulatorGetter trackGetter, AccumulatorGrowFunction trackGrowthFunction,
FilterFunction growAboveMaxBreadthFilterFunction)

I’m concerned that the extensive use of pointers to member function for these
functions is an inefficient design pattern. But this is only a suspicion, not
something I am certain about.