[webkit-reviews] review granted: [Bug 137165] Support modern for loops over StringView code units and code points : [Attachment 239162] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 3 09:08:21 PDT 2014


Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 137165: Support modern for loops over StringView code units and code points
https://bugs.webkit.org/show_bug.cgi?id=137165

Attachment 239162: Patch
https://bugs.webkit.org/attachment.cgi?id=239162&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is OK, but I think the m_alreadyIncremented boolean is confusing. What I
proposed was actually the opposite of what you wrote, showing that the two of
us don’t even agree on this!


More information about the webkit-reviews mailing list