[webkit-reviews] review granted: [Bug 136819] Move DragController::createFragmentFromDragData implementation to the editor : [Attachment 238243] Try to fix EFL build

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 136819: Move DragController::createFragmentFromDragData implementation to
the editor
https://bugs.webkit.org/show_bug.cgi?id=136819

Attachment 238243: Try to fix EFL build
https://bugs.webkit.org/attachment.cgi?id=238243&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238243&action=review


A good step in the right direction. I suspect we can keep refactoring this to
make the code even tighter over time.

> Source/WebCore/editing/win/EditorWin.cpp:51
> +template <typename PlatformDragData>
> +static PassRefPtr<DocumentFragment>
createFragmentFromPlatformData(PlatformDragData* platformDragData, Frame&
frame)

Should take PlatformDragData& instead of PlatformDragData*.

I’m also surprised this needs to be a template. Are all four functions called
here really overloaded for two different types!?