[webkit-reviews] review granted: [Bug 42704] WebKitTestRunner needs to print history delegate information : [Attachment 228019] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 27 20:10:27 PDT 2014


Sam Weinig <sam at webkit.org> has granted Mark Rowe (bdash) <mrowe at apple.com>'s
request for review:
Bug 42704: WebKitTestRunner needs to print history delegate information
https://bugs.webkit.org/show_bug.cgi?id=42704

Attachment 228019: Patch
https://bugs.webkit.org/attachment.cgi?id=228019&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228019&action=review


> Tools/WebKitTestRunner/TestController.cpp:1324
> +    WKRetainPtr<WKURLRef> urlWK(AdoptWK,
WKNavigationDataCopyURL(navigationData));
> +    WKRetainPtr<WKStringRef> urlStringWK(AdoptWK,
WKURLCopyString(urlWK.get()));

I prefer the WKRetainPtr<WKURLRef> urlWK = adoptWK() style, as it matches the
normal RetainPtr.


More information about the webkit-reviews mailing list