[webkit-reviews] review granted: [Bug 130884] [iOS][WK2] Adjust the tile coverage on the scrollview's edges : [Attachment 228020] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 27 20:06:04 PDT 2014
mitz at webkit.org <mitz at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 130884: [iOS][WK2] Adjust the tile coverage on the scrollview's edges
https://bugs.webkit.org/show_bug.cgi?id=130884
Attachment 228020: Patch
https://bugs.webkit.org/attachment.cgi?id=228020&action=review
------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=228020&action=review
> Source/WebCore/platform/ios/ScrollViewIOS.mm:168
> + IntSize contentSize = contentsSize();
> + if (futureRect.maxX() > contentSize.width())
> + futureRect.setX(contentSize.width() - futureRect.width());
> + if (futureRect.maxY() > contentSize.height())
> + futureRect.setY(contentSize.height() - futureRect.height());
> + if (futureRect.x() < 0)
> + futureRect.setX(0);
> + if (futureRect.y() < 0)
> + futureRect.setY(0);
> +
Can’t this be written more concisely as intersecting futureRect with the rect {
FloatPoint(), contentSize() }?
More information about the webkit-reviews
mailing list