[webkit-reviews] review granted: [Bug 130827] Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree controls, etc., and reconcile UI with childNodeIds : [Attachment 228018] patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted James Craig
<jcraig at apple.com>'s request for review:
Bug 130827: Web Inspector: AXI: expose selectedChildNodeIds of list boxes, tree
controls, etc., and reconcile UI with childNodeIds
https://bugs.webkit.org/show_bug.cgi?id=130827

Attachment 228018: patch
https://bugs.webkit.org/attachment.cgi?id=228018&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=228018&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:1561
> +		   for (const auto& selectedChildObject : selectedChildren) {

No need for const, IIRC.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:393
> +		       this._accessibilityNodeChildrenRow.label =
WebInspector.UIString("Child"); 	       

I'd say Children is fine for the singular case too. Just not if a count is part
if the label.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:414
> +		       this._accessibilityNodeSelectedChildrenRow.label =
WebInspector.UIString("Selected Item"); 	       

Hmm. I think this is fine though.