[webkit-reviews] review granted: [Bug 134347] Define TARGET_OS_IPHONE to 0 for non-darwin ports : [Attachment 233904] It reads slightly better..

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Laszlo Gombos
<laszlo.gombos at webkit.org>'s request for review:
Bug 134347: Define TARGET_OS_IPHONE to 0 for non-darwin ports
https://bugs.webkit.org/show_bug.cgi?id=134347

Attachment 233904: It reads slightly better..
https://bugs.webkit.org/attachment.cgi?id=233904&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233904&action=review


It’s worth noting why this is different from our usual strategy. Unlike, say,
WebCore, WebKit2 has public header files, and in public header files we need to
use conditionals that don’t rely on WebKit internals such as Platform.h.

Understanding that leads to the thought that for EFL and GTK, this use of
TARGET_OS_IPHONE in public header files might pose a problem, for the same
reason that PLATFORM(IOS) would be a problem on the Mac and iOS platform. We
may need to run a script to strip those out for those platforms as part of the
“installing public headers” process.

> Source/WTF/wtf/Platform.h:1049
> +/* Set TARGET_OS_IPHONE to 0 by default to allow using it as a guard 
> + * in cross-platform the same way as it is used in OS(DARWIN) code */ 

Normally we’d put a period at the end of a sentence.